chore: update github action to new setup-java v2 #9068
Conversation
The v2 of actions/setup-java supports caching out of the box https://github.com/actions/setup-java\#caching-maven-dependencies Updating to v2 will give us future improvements to caching configuration automatically. since v1 used the zulu distribution https://github.com/actions/setup-java/blob/main/README.md\#v2-vs-v1 I stuck with it. Providing the distribution is now mandatory. Once actions/runner-images#3859 is done and the VMs have temurin pre-installed we should switch to save additional time.
|
relates to #9067 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I think https://github.com/dhis2/dhis2-core/blob/master/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/gist/GistLogic.java#L93 this needs to be deleted - didn't think it through correctly so this must be relaxed so that UIDs which have no digit still can be attribute paths. |
Thank you for looking into it 😄 I assume you will take care of deleting that, correct? |
Not today, since I am off - so if you want it today just delete it in your branch ;) |
Oh I am very sorry for pinging you 😅 Have a great day off. Turn of the phone or the github/slack apps 😂 I will deleted it! |
|
Just so I or others can find it later. If the runner the job is assigned to has no maven cache it will print so in the logs. See example at https://github.com/dhis2/dhis2-core/runs/3906542924?check_suite_focus=true#step:3:890 |
|
waiting on #9076 to be merged |
teleivo
added
the
run-api-tests
The v2 of actions/setup-java supports caching out of the box
https://github.com/actions/setup-java\#caching-maven-dependencies
Updating to v2 will give us future improvements to caching configuration
automatically.
since v1 used the zulu distribution https://github.com/actions/setup-java/blob/main/README.md\#v2-vs-v1
I stuck with it. Providing the distribution is now mandatory.
Once actions/runner-images#3859 is done
and the VMs have temurin pre-installed we should switch to save
additional time.