refactor: Beautify DataApprovalServiceC.O.G.Test #9064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
jbee
reviewed
Oct 18, 2021
...ore/src/test/java/org/hisp/dhis/dataapproval/DataApprovalServiceCategoryOptionGroupTest.java
Show resolved
Hide resolved
jbee
approved these changes
Oct 19, 2021
vilkg
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DataApprovalServiceCategoryOptionGroupTesthad maximum line lengths enforced by Spotless, it made the code much less readable. This PR reformats the code, as much as possible, to at or near the original readability while staying within the Spotless line lengths.I started this reformatting as I was working on pull/9052 to satisfy DHIS2-11981, but the changes became extensive enough that I decided it would be better in a separate PR.