feat: storedby and last updated in enrollment analytics [DHIS2-11775] #8909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
d-bernat
suggested changes
Oct 4, 2021
| Set<AnalyticsPeriodBoundary> boundaries = map.get( programStage ); | ||
|
|
||
| String eventTableName = "analytics_event_" + programIndicator.getProgram().getUid(); | ||
| sql += " (select count(*) from " + eventTableName + " where " + eventTableName + |
There was a problem hiding this comment.
waht do you think about replacement of '... ( select count(*)..) > 0' with 'exists(select 1 from ... limit 1)'
There was a problem hiding this comment.
makes sense and should improve performances. So generally speaking I agree with that.
However this code was just moved from somewhere else and is not meant to be modified within this ticket scope.
I'd suggest to create a specific task for it
There was a problem hiding this comment.
Ok, agree, can you please create a ticket for this and assign it to me? Please in comment let me know where is this code coming from. I would like to change it as well. Thank you :-)
d-bernat
approved these changes
Oct 4, 2021
maikelarabori
approved these changes
Oct 4, 2021
gnespolino
deleted the
DHIS2-11775_storedby_lastupdated_enrollments_analytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the time condition rendering a bit to accommodate enrollments.