fix: broken linked account feature #19565
Open
+28
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Users could not switch between linked account users.
Cause:
When the log out handler
(DhisOidcLogoutSuccessHandler)
, was called and tried to set the user we want to switch to with the methodsetActiveLinkedAccounts()
, nothing happened because the there was no transaction involved, because it called the UserStore directly, instead of going through the service layer.So when it tried to persist the updated
lastLogin
field, nothing happened.Solution:
Add the
setActiveLinkedAccounts()
method to the UserService and annotate it with @transactional and make the log out handler call the new method.Automatic tests:
Automatic tests not available, because it needs a full setup with an external IDP and tests with E2E.
Manual test:
linked_accounts.enabled = on
andlinked_accounts.relogin_url = http://localhost:8080
in dhis.confhttp://localhost:8080/dhis-web-commons-security/logout.action?switch=userb¤t=usera