feat: skip citus dynamically [DHIS2-18134] #18720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Nespolino <g.nespolino@gmail.com>
gnespolino
added
run-api-tests
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/ResourceTableController.java
Show resolved
Hide resolved
| * @param type the table type | ||
| * @return true if citus should be skipped, false otherwise | ||
| */ | ||
| public boolean isSkippedCitusType(AnalyticsTableType type) { |
There was a problem hiding this comment.
Suggested change
| public boolean isSkippedCitusType(AnalyticsTableType type) { | |
| public boolean skipCitusType(AnalyticsTableType type) { |
| @@ -103,6 +106,16 @@ public boolean isSkipPrograms() { | |||
| return !skipPrograms.isEmpty(); | |||
| } | |||
|
|
|||
| /** | |||
| * Indicates whether the export process should skip citus for the given table type. | |||
There was a problem hiding this comment.
Suggested change
| * Indicates whether the export process should skip citus for the given table type. | |
| * Indicates whether the export process should skip Citus table for the given table type. |
| * Indicates whether the export process should skip citus for the given table type. | ||
| * | ||
| * @param type the table type | ||
| * @return true if citus should be skipped, false otherwise |
There was a problem hiding this comment.
Suggested change
| * @return true if citus should be skipped, false otherwise | |
| * @return true if Citus should be skipped, false otherwise |
d-bernat
approved these changes
Oct 2, 2024
Signed-off-by: Giuseppe Nespolino <g.nespolino@gmail.com>
Signed-off-by: Giuseppe Nespolino <g.nespolino@gmail.com>
Signed-off-by: Giuseppe Nespolino <g.nespolino@gmail.com>
maikelarabori
approved these changes
Oct 3, 2024
Signed-off-by: Giuseppe Nespolino <g.nespolino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a parameter
skipCitusTablesin theResourceController, to allow selectively and dynamically skipping the distribution of tables even when Citus is enabled.