Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): micrometer libraries should be kept in sync #11440

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Aug 15, 2022

as they are released together
micrometer-spring-legacy is EOL and not released anymore micrometer-metrics/micrometer#1662
We should investigate whether the mix of current and EOL spring-legacy actually works

as they are released together
micrometer-spring-legacy is EOL and not released anymore micrometer-metrics/micrometer#1662
We should investigate whether the mix of current and EOL spring-legacy actually works
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teleivo teleivo enabled auto-merge (squash) August 15, 2022 08:08
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #11440 (d01e218) into master (1ed1372) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11440   +/-   ##
=========================================
  Coverage     63.24%   63.24%           
+ Complexity    27341    27340    -1     
=========================================
  Files          3199     3199           
  Lines        112879   112879           
  Branches      13285    13285           
=========================================
+ Hits          71388    71389    +1     
  Misses        35362    35362           
+ Partials       6129     6128    -1     
Flag Coverage Δ
integration 45.50% <ø> (+<0.01%) ⬆️
integration-h2 32.94% <ø> (ø)
unit 28.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/hisp/dhis/common/DimensionalItemId.java 84.72% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfd330...d01e218. Read the comment docs.

@teleivo teleivo merged commit df33d5b into master Aug 16, 2022
@teleivo teleivo deleted the micrometer-deps-sync branch August 16, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants