fix: [ANDROAPP-7574] make navigation context safe #4829
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses ANDROAPP-7574 by making TEI dashboard navigation and UI interactions safer when triggered from background work, reducing crashes caused by using a Fragment context after it’s no longer attached.
Changes:
- Switch TEIDataPresenter UI calls to run on the UI dispatcher via
withContext(dispatcher.ui()). - Guard TEIDataFragment navigation/dialog entry points with
if (!isAdded) returnto avoidrequireContext()/FragmentManagerusage when detached.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/org/dhis2/usescases/teiDashboard/dashboardfragments/teidata/TEIDataPresenter.kt | Moves navigation and message UI calls onto the UI dispatcher while running repository/use-case work on IO. |
| app/src/main/java/org/dhis2/usescases/teiDashboard/dashboardfragments/teidata/TEIDataFragment.kt | Adds attachment checks before starting activities or showing the org unit selector dialog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xavimolloy
force-pushed
the
ANDROAPP-7574
branch
from
4a11370 to
a52bad7
Compare
andresmr
approved these changes
Apr 27, 2026
mmmateos
approved these changes
Apr 28, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt is attached
Description
Link the JIRA issue.
Please provide a clear definition of the problem and explain your solution.