fix(security): disable cleartext HTTP traffic by default#4813
Open
IvanBila wants to merge 1 commit into
Open
Conversation
IvanBila
force-pushed
the
fix/disable-cleartext-traffic
branch
from
509662f to
07fa9d3
Compare
Replaces the global android:usesCleartextTraffic="true" with a network security config that denies cleartext by default. The app handles PHI/PII and the previous manifest setting exposed credentials and patient data to on-path attackers (rogue Wi-Fi, corporate proxies) on any HTTP DHIS2 deployment.
IvanBila
force-pushed
the
fix/disable-cleartext-traffic
branch
from
07fa9d3 to
f7c964a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
android:usesCleartextTraffic="true"inAndroidManifest.xmlwith a Network Security Config that blocks cleartext HTTP by default. Addsapp/src/main/res/xml/network_security_config.xmlwithcleartextTrafficPermitted="false"and system trust anchors.Why
The app handles PHI/PII. The explicit
usesCleartextTraffic="true"was overriding Android 9+'s secure default, exposing credentials and patient data to MITM attacks on anyhttp://DHIS2 instance.Behavior change
java.io.IOException: Cleartext HTTP traffic to <host> not permitted<domain-config cleartextTrafficPermitted="true">— ideally via adebugmanifest override, not globally.Test plan
dhis2Debugagainst HTTPS server — login + sync workdhis2Release,dhis2PlayServicesRelease,dhis2TrainingReleasebuild and install