-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-17991] Show orgUnit selector in Enter details now #3824
feat: [DHIS2-17991] Show orgUnit selector in Enter details now #3824
Conversation
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrikmv,
This is a great start 👏 !
I noticed runtime errors when clicking the Complete
/Save without Completing
button without first selecting an orgUnit. Can you add validation for the orgUnit selector? It should behave like the other form validation (take a look at relatedStageWidgetIsValid and ValidationFunctionsByLinkMode as a starting point)
Screen.Recording.2024-10-14.at.14.23.47.mov
Thanks!
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🥳
🚀 Deployed on https://deploy-preview-3824.capture.netlify.dhis2.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 2.42,2.41.2,2.40.6,2.39.8 versions
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
🎉 This PR is included in version 101.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
DHIS2-17991:
Enter details now
part of the related stages widget