Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-17991] Show orgUnit selector in Enter details now #3824

Merged
merged 7 commits into from
Oct 21, 2024
Merged

feat: [DHIS2-17991] Show orgUnit selector in Enter details now #3824

merged 7 commits into from
Oct 21, 2024

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Oct 1, 2024 •
edited
Loading

DHIS2-17991:

  • adds the OrgUnitSelector component to the Enter details now part of the related stages widget
  • makes small changes to the info box

@henrikmv henrikmv marked this pull request as ready for review October 14, 2024 08:58
@henrikmv henrikmv requested a review from a team as a code owner October 14, 2024 08:58
simonadomnisoru
simonadomnisoru reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikmv,
This is a great start 👏 !
I noticed runtime errors when clicking the Complete/Save without Completing button without first selecting an orgUnit. Can you add validation for the orgUnit selector? It should behave like the other form validation (take a look at relatedStageWidgetIsValid and ValidationFunctionsByLinkMode as a starting point)

Screen.Recording.2024-10-14.at.14.23.47.mov

Thanks!

@henrikmv
Merge branch 'master' of https://github.com/dhis2/capture-app into hv…
bc2d835 
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
@henrikmv
feat: add validation
a520044
@henrikmv
Merge branch 'master' of https://github.com/dhis2/capture-app into hv…
9eb051f 
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
simonadomnisoru
simonadomnisoru approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3824.capture.netlify.dhis2.org

geethaalwan
geethaalwan approved these changes Oct 17, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.2,2.40.6,2.39.8 versions

@henrikmv
Merge branch 'master' of https://github.com/dhis2/capture-app into hv…
51c55f8 
…/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow
@henrikmv henrikmv merged commit bf2f1ca into master Oct 21, 2024
59 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-17991_ShowOrgUnitSelectorInEnterDetailsNow branch October 21, 2024 07:10
dhis2-bot added a commit that referenced this pull request Oct 21, 2024
@dhis2-bot
chore(release): cut 101.13.0 [skip release]
0ae601f 
# [101.13.0](v101.12.2...v101.13.0) (2024-10-21)

### Features

* [DHIS2-16992] Fixed size for changelog modal and columns ([#3834](#3834)) ([3b021cf](3b021cf))
* [DHIS2-17991] Show orgUnit selector in Enter details now ([#3824](#3824)) ([bf2f1ca](bf2f1ca))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

@geethaalwan geethaalwan geethaalwan approved these changes

Assignees
No one assigned
Labels
e2e-tests released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrikmv @dhis2-bot @simonadomnisoru @geethaalwan