test(data-workspace): add tests#26
Merged
Merged
Conversation
mediremi
commented
Jul 14, 2021
| @@ -0,0 +1,105 @@ | |||
| import React from 'react' | |||
| import { CustomDataProvider } from '@dhis2/app-runtime' | |||
| import { render, screen, waitFor, waitForElementToBeRemoved } from '@testing-library/react' | |||
Contributor
Author
There was a problem hiding this comment.
I used @testing-library/react instead of enzyme for these tests as the various utils provided such as waitForElementToBeRemoved and getByRole made the tests much clearer.
Mohammer5
approved these changes
Jul 20, 2021
Mohammer5
suggested changes
Jul 20, 2021
Mohammer5
approved these changes
Jul 20, 2021
Contributor
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.