Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make useD2 argument optional #67

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix: make useD2 argument optional #67

merged 1 commit into from
Feb 19, 2021

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Feb 19, 2021

I noticed when working in dashboard-app that the useD2 hook requires an object be passed as arguments[0], even if that object is empty. It's cleaner to set a default empty object so that it can be useD2() instead of useD2({})

@amcgee amcgee merged commit b885fe5 into master Feb 19, 2021
@amcgee amcgee deleted the fix-optional-arg-useD2 branch February 19, 2021 13:11
dhis2-bot added a commit that referenced this pull request Feb 19, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-02-19)

### Bug Fixes

* make useD2 argument optional ([#67](#67)) ([b885fe5](b885fe5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants