feat: parse additional namespaces from d2.config.js and add to manifest.webapp [LIBS-638]
#860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVandivier
commented
Jul 3, 2024
| }, | ||
| { | ||
| src: 'safari-pinned-tab.svg', | ||
| sizes: '16x16', |
Contributor
Author
There was a problem hiding this comment.
Fixes the Application tab crash in Chrome dev tools -- slack thread
eirikhaugstulen
approved these changes
Jul 3, 2024
eirikhaugstulen
left a comment
eirikhaugstulen
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Great job, @KaiVandivier.
dhis2-bot
added a commit
that referenced
this pull request
Jul 3, 2024
# [11.6.0](v11.5.1...v11.6.0) (2024-07-03) ### Features * parse additional namespaces from `d2.config.js` and add to `manifest.webapp` [LIBS-638] ([#860](#860)) ([62782fe](62782fe))
Contributor
|
🎉 This PR is included in version 11.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Jul 8, 2024
# [12.0.0-alpha.3](v12.0.0-alpha.2...v12.0.0-alpha.3) (2024-07-08) ### Bug Fixes * **alerts:** ensure hiding works correctly and alerts are not re-added [DHIS2-15438] ([#859](#859)) ([6b11fff](6b11fff)) * fixed dimensions plugins [LIBS-634] ([#858](#858)) ([1f717f3](1f717f3)) * small text change in changelog ([824dd2f](824dd2f)) ### Features * cleanup plugin error boundary [UX-136] ([#856](#856)) ([de252fe](de252fe)) * parse additional namespaces from `d2.config.js` and add to `manifest.webapp` [LIBS-638] ([#860](#860)) ([62782fe](62782fe))
Contributor
|
🎉 This PR is included in version 12.0.0-alpha.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBS-638
Follow-up from DHIS2-17546
Also includes
sizes: '16x16'tomanifest.jsonto fix the Chrome "Application" tab crash in dev tools