Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles (partly) #10 by returning an empty DataFrame instead of an error message when no results are returned by the API (in combination with a status 200).
Some remarks:
df=False
option also returning json with no results.locations
,...), I also returned theDataFrame
with a hard coded set of names.The tests do still fail as the API is not returning any information. Fixing this is out of scope of this PR, as it would require having fixture or mocked data as the input of the plot functions instead of relying on the API when running the tests.