refactor: add types to cli command options #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenbonito
approved these changes
Apr 7, 2021
|
Closes #1211 BTW |
|
When will this be published to the npm registry? |
|
There was a minor regression introduced to tests as a part of: #1175 - after that gets fixed, I would like to release a new verison |
This was referenced May 21, 2021
1 task
1 task
1 task
1 task
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add types to CLI command options arguments
Motivation and Context
Serverless has introduced a mandatory type definition for CLI arguments
https://www.serverless.com/framework/docs/deprecations/#CLI_OPTIONS_SCHEMA
How Has This Been Tested?
I did not test it, just used common sense to define the types, it definitely needs review from someone else.
The framework also allows for a
defaultargument value, which I'm not really sure it's useful at this time.