Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1035 - Add apiKeyId to identity information #1169

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

jeroenvollenbrock
Copy link
Contributor

Description

Adds the ApiKeyId to the identity object in the requestContext of the LambdaProxyIntegrationEvent

Motivation and Context

When testing locally it sometimes is needed to read out the apiKeyId instead of the apiKey
#1035

How Has This Been Tested?

I npm link'ed this branch in my local environment and verified the apiKeyId was available in the event.

There seems to be no unit test that covers the contents the identity object, except for a file in the folder called "old-unit". Please let me know if adding an additional expect there is appreciated.

Screenshots (if appropriate):

Screenshot

Adds the ApiKeyId to the identity object in the requestContext of the LambdaProxyIntegrationEvent
@frozenbonito
Copy link
Contributor

Thank you @jeroenvollenbrock.
Would you be able to add the environment variable SLS_API_KEY_ID to the documentation?
https://github.com/dherault/serverless-offline#environment-variables

@jeroenvollenbrock
Copy link
Contributor Author

Done!

@jeroenvollenbrock
Copy link
Contributor Author

@frozenbonito The three failed CI tasks seem unrelated, they might need to be retriggered

@frozenbonito frozenbonito merged commit 28839d1 into dherault:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants