Set Cron* types and defaults to v1beta1 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
Nov 12, 2019
JamesGuthrie
force-pushed
the
use-batch-v1beta1
branch
from
8b7885b
to
0321465
Compare
According to the Kubernetes documentation [1]: Note: CronJob resource in batch/v2alpha1 API group has been deprecated starting from cluster version 1.8. You should switch to using batch/v1beta1, instead, which is enabled by default in the API server. Examples in this document use batch/v1beta1 in all examples. [1]: https://kubernetes.io/docs/tasks/job/automated-tasks-with-cron-jobs/
JamesGuthrie
force-pushed
the
use-batch-v1beta1
branch
from
0321465
to
79cfd6f
Compare
|
@Gabriel439 I've updated |
|
@JamesGuthrie: I don't think that is an issue. We should expect this to change the hash since the contents of the resource include the I'll merge this tomorrow if nobody objects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Kubernetes documentation 1:
Note: CronJob resource in batch/v2alpha1 API group has been deprecated
starting from cluster version 1.8. You should switch to using
batch/v1beta1, instead, which is enabled by default in the API server.
Examples in this document use batch/v1beta1 in all examples.
This should fix the problem reported in #81