Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix build to reinstate -Werror #781

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Conversation

Gabriella439
Copy link
Collaborator

A refactor of the Nix build accidentally removed the -Werror flag, which
caused some warnings to get past CI. This change fixes that and removes the
warnings.

A refactor of the Nix build accidentally removed the `-Werror` flag, which
caused some warnings to get past CI.  This change fixes that and removes the
warnings.
@ocharles
Copy link
Member

You may still want to look at adding -fwarn-incomplete-uni-patterns as that isn't in -Wall, but I really wish it was!

@Gabriella439
Copy link
Collaborator Author

@ocharles: Yes, my plan was to merge this first and then add -fwarn-incomplete-uni-patterns in #780 since the changes in the other branch are necessary to avoid that warning failing the build.

@Gabriella439 Gabriella439 merged commit f5928e4 into master Jan 17, 2019
@Gabriella439 Gabriella439 deleted the gabriel/reinstate_Werror branch January 17, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants