Change how dhall repl handles prior definitions
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is so that more code type-checks within a REPL session. For example, before this change the following session fails: ```haskell ⊢ :let Either = λ(a : Type) → λ(b : Type) → < Left : a | Right : b > ⊢ :let Example = < Left : Natural | Right : Bool > Example : Type ⊢ Example.Left Example : Type Error: Not a record or a union Example.Left (stdin):1:1 ``` After this change, the same session works: ``` [⊢ :let Example = < Left : Natural | Right : Bool > Example : Type ⊢ Example.Left λ(Left : Natural) → < Left = Left | Right : Bool > ``` The difference is in how we incorporate prior definitions when type-checking code. Before this change prior definitions were added to the context, which leads to type-checking failures because type synonyms don't work when used in this way. After this change we incorporate them as extra `let` definitions (same as normalization).
|
cc: @basile-henry since you may have run into this issue when testing union alternative completion in #727 |
|
@Gabriel439 I have ran into this! It was late and I thought I didn't know how to properly setup union types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change is so that more code type-checks
within a REPL session.
For example, before this change the following session fails:
After this change, the same session works:
The difference is in how we incorporate prior definitions when
type-checking code. Before this change prior definitions were added
to the context, which leads to type-checking failures because type
synonyms don't work when used in this way. After this change we
incorporate them as extra
letdefinitions (same as normalization).