Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-let #675

Merged
merged 5 commits into from
Nov 13, 2018
Merged

Add support for multi-let #675

merged 5 commits into from
Nov 13, 2018

Conversation

Gabriella439
Copy link
Collaborator

... as standardized in: dhall-lang/dhall-lang#266

This also adds dhall lint support for consolidating nested let expressions

@Gabriella439
Add support for multi-let
7e527c7 
... as standardized in: dhall-lang/dhall-lang#266

This also adds `dhall lint` support for consolidating nested `let` expressions
@Gabriella439
Copy link
Collaborator Author

Note that in the process of implementing this I realized that I forgot to standardize how to encode/decode multi-let expressions, so I will finish that before merging this

@Gabriella439 Gabriella439 mentioned this pull request Nov 10, 2018
Closed
@joneshf
Copy link
Collaborator

joneshf commented Nov 10, 2018

Any thoughts on how we might mitigate that happening in the future?

@Gabriella439
Copy link
Collaborator Author

@joneshf: Usually I do this by implementing the proposal in Haskell before merging, but I forgot to do so this time

@Gabriella439 Gabriella439 merged commit 8a5bfaa into master Nov 13, 2018
@Gabriella439 Gabriella439 deleted the gabriel/multi_let_3 branch November 13, 2018 16:02
@f-f f-f mentioned this pull request Nov 23, 2018
Closed
@sjakobi sjakobi mentioned this pull request Aug 1, 2019
Closed
sjakobi added a commit that referenced this pull request Aug 20, 2019
@sjakobi
Mostly revert "Add support for multi-let (#675)"
34a39ef 
This reverts commit 8a5bfaa.
sjakobi added a commit that referenced this pull request Aug 20, 2019
@sjakobi
Treat multi-lets as syntactic sugar
dacd6d4 
Closes #1185.

This mostly reverts "Add support for multi-`let` (#675)" /
8a5bfaa.
@sjakobi sjakobi mentioned this pull request Aug 20, 2019
Merged
sjakobi added a commit that referenced this pull request Aug 28, 2019
@sjakobi
Treat multi-lets as syntactic sugar
0d1f6e1 
Closes #1185.

This mostly reverts "Add support for multi-`let` (#675)" /
8a5bfaa.
sjakobi added a commit that referenced this pull request Aug 31, 2019
@sjakobi
Treat multi-lets as syntactic sugar
5bc4241 
Closes #1185.

This mostly reverts "Add support for multi-`let` (#675)" /
8a5bfaa.

Also:

* Add fields for Src
  This is useful for to make 'Note's less noisy during debugging:

      first srcText expr
sjakobi added a commit that referenced this pull request Aug 31, 2019
@sjakobi
Treat multi-lets as syntactic sugar
0634a23 
Closes #1185.

This mostly reverts "Add support for multi-`let` (#675)" /
8a5bfaa.

Also:

* Add fields for Src
  This is useful for to make 'Note's less noisy during debugging:

      first srcText expr
sjakobi added a commit that referenced this pull request Aug 31, 2019
@sjakobi
Treat multi-lets as syntactic sugar (#1242)
72fd2ac 
Closes #1185.

This mostly reverts "Add support for multi-`let` (#675)" /
8a5bfaa.

Also:

* Add fields for Src
  This is useful for to make 'Note's less noisy during debugging:

      first srcText expr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @joneshf