Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Date / Time / TimeZone #2247

Merged
merged 14 commits into from
Jul 24, 2021
Merged

Add support for Date / Time / TimeZone #2247

merged 14 commits into from
Jul 24, 2021

Conversation

Gabriella439
Copy link
Collaborator

… as standardized in dhall-lang/dhall-lang#1191

@Gabriella439
Copy link
Collaborator Author

This PR also highlights an issue with our GitHub action CI: it doesn't exercise changes to dhall that affect downstream packages. For example, if the change to the dhall package breaks the dhall-json package then the GitHub CI will still pass because the dhall-json build is building against the latest dhall from Hackage, not the local dhall package.

@Gabriella439 Gabriella439 merged commit 3efdc6d into master Jul 24, 2021
@Gabriella439 Gabriella439 deleted the gabriel/times branch July 24, 2021 05:22
@sjakobi
Copy link
Collaborator

sjakobi commented Jul 26, 2021

For example, if the change to the dhall package breaks the dhall-json package then the GitHub CI will still pass because the dhall-json build is building against the latest dhall from Hackage, not the local dhall package.

@Gabriel439 I don't understand what problem you're describing here. If the dhall-json build would attempt to use the latest dhall from Hackage, surely it should fail because Date, DateTime and the other new exports would be out of scope. CI, including the dhall-json jobs, is green though!

@Gabriella439
Copy link
Collaborator Author

@sjakobi: You're right. I misdiagnosed the problem. Downstream dhall-* packages are building against the local dhall package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants