Skip to content

Commit

Permalink
Upgrade Node to v20.10.0 (#94)
Browse files Browse the repository at this point in the history
Replace node-static with serve to fix an issue related to IP resolving:
microsoft/playwright#20784
  • Loading branch information
dguo authored Jan 2, 2024
1 parent c9499a6 commit 148bfa0
Show file tree
Hide file tree
Showing 7 changed files with 2,135 additions and 870 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ jobs:
run: yarn run format:check
- name: Lint the code
run: yarn run lint
- name: Start the server
run: yarn run start:prod &
- name: Build the site
run: yarn run build:prod
env:
MOCK_HEADLINES: 1
- name: Serve the site
run: yarn serve dist -p 3000 &
- name: Run tests
run: yarn run test:ci
timeout-minutes: 3
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.15.1
20.10.0
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 16.15.1
nodejs 20.10.0
546 changes: 546 additions & 0 deletions .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
defaultSemverRangePrefix: ""
nodeLinker: "node-modules"

nodeLinker: node-modules

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
spec: "@yarnpkg/plugin-interactive-tools"

yarnPath: .yarn/releases/yarn-3.2.1.cjs
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"get-headlines": "node ./src/get-headlines",
"lint": "eslint . && sass-lint -v -q",
"start": "yarn install && yarn run get-headlines && parcel --port 3000 site/index.html",
"start:prod": "yarn install && yarn run build:prod && static dist --port 3000",
"start:prod": "yarn install && yarn run build:prod && serve dist -p 3000",
"test": "playwright test",
"test:ci": "wait-for-localhost 3000 && yarn run test"
},
Expand Down Expand Up @@ -38,20 +38,20 @@
"storage-available": "1.1.0"
},
"devDependencies": {
"@parcel/packager-raw-url": "2.6.2",
"@parcel/transformer-sass": "2.6.2",
"@parcel/transformer-webmanifest": "2.6.2",
"@playwright/test": "1.23.1",
"@parcel/packager-raw-url": "2.10.3",
"@parcel/transformer-sass": "2.10.3",
"@parcel/transformer-webmanifest": "2.10.3",
"@playwright/test": "1.40.1",
"axios": "0.27.2",
"dotenv": "16.0.1",
"eslint": "8.19.0",
"eslint-config-prettier": "8.5.0",
"node-static": "0.7.11",
"parcel": "2.6.2",
"parcel-resolver-ignore": "2.1.3",
"parcel": "2.10.3",
"parcel-resolver-ignore": "2.2.0",
"prettier": "2.7.1",
"process": "0.11.10",
"sass-lint": "1.13.1",
"serve": "14.2.1",
"wait-for-localhost-cli": "3.0.0"
},
"browserslist": [
Expand Down
Loading

0 comments on commit 148bfa0

Please sign in to comment.