Implement visual selector override of price data Re #3505#3506
Open
Implement visual selector override of price data Re #3505#3506
Conversation
This was referenced Oct 15, 2025
Owner
Author
|
@Batwam please absolutely do not write irrelevant things in the issue queue, submit a PR |
3cdc658 to
549e167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3505
Related to
This adds a new filter field shown only in restock mode
price_change_custom_include_filters, which is separate to theinclude_filtersof the content change filter modetodo
cant decideor similar for restock detectionprice_change_custom_include_filtersselector for the price data'Beginning at 1 099,00 € tax incl. tax incl.'that they correct convert price and currency (EURshown)this is going to break/not work when this case happens.. because either new 'discount' element is going to go missing once the price returns.. so its not a great solution i think
Anyway, here's how it looks