Fix or suppress warnings and format code #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out signatures don't play so nicely with rustfmt. Make it clearer which bits of the Python API we are ignoring by using an `ignore!` macro.
`const_fn` is available in the MSRV 1.41.1, so make this the default.
|
With this in place, the only warning is in If there are no objections, I will merge this and my other PRs and make a 0.6 release soon. |
|
I had a cursory look at your PRs and have no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or suppress all warnings, including clippy lints. A new
make clippytarget is added to run clippy.Reformat using the latest versions of
rustfmt.There were some formatting conflicts caused by the commented out prototypes in the
syscrates. I have switched these to using anignore!macro so that they can be formatted better, and also makes it clearer what's happening.