Initial serde support #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbt
approved these changes
Sep 28, 2020
Cargo.toml
Outdated
| @@ -49,7 +54,10 @@ path = "python3-sys" | |||
| version = "0.5.1" | |||
|
|
|||
| [features] | |||
| default = ["python3-sys"] | |||
| default = ["python3-sys", "serde-support"] | |||
There was a problem hiding this comment.
Do we want to make this a default? I would assume existing users don't care about it, and we wouldn't want them to have to pull in an extra stack of dependencies if they're not using serde.
There was a problem hiding this comment.
Good point. I only wanted CI to run the tests. I updated Makefile for that and made the feature default off.
Converts between serde types and PyObject. This can make FromPyObject/ ToPyObject implementations easier. The feature is gated by `serde-convert`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts between serde types and PyObject. This can make FromPyObject/
ToPyObject implementations easier.