Handle iceCandidate event with no candidate #1507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceCandidate event with no candidate means all candidates are gathered.
|
I've got a fix for this in the beta branch now. Thanks for the heads up and initial research! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses compatibility with WeRIFT v.0.20.0 and later which modified onIceCandidate behavior to be the same as browser API. Receiving an iceCandidate event with no candidate means all candidates are gathered.
This code just ignores evens with no candidate property, but we could also add an else and log ICE gathering complete for debug purposes if you think that is useful.