Add support for custom election tick#9725
Open
LakshimiRam-073 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
election-tickas a configurable sub-option to the existing--raftsuperflag for both Alpha and Zero nodes.Currently,
ElectionTickis hardcoded to20inconn/node.go:91(equivalent to 2 seconds at the 100ms tick interval). This makes it impossible for operators to control leader election priority across nodes deployed in heterogeneous network topologies -- for example, nodes spread across different network segments with varying inter-node RTTs (1-2ms within the same segment vs. 10-50ms across segments), or nodes behind different network switches with asymmetric bandwidth, latency, and jitter characteristics.Changes:
worker/server_state.go— Addedelection-tick=20toRaftDefaultsstring (preserves backward compatibility)conn/node.go— Readelection-tickfromx.WorkerConfig.Raftconfig instead of hardcoded valueelection-tick >= 10 * HeartbeatTickper etcd/raft library requirementsUse case: In deployments where Alpha nodes span different network segments with asymmetric latency, operators can now bias leadership toward low-latency nodes:
This ensures the Raft leader stays in the segment closest to application servers, avoiding unnecessary write latency degradation from suboptimal leader placement after elections.
Default behavior is unchanged — without specifying
election-tick, nodes use the previous value of20(2 second timeout).Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.docs repo staged and linked here.