fix(upgrade): check commit SHA to find running dgraph version #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for certain binaries such as v22.0.0, dgraph version that gets printed is "local". We now instead use the commit sha to find the right running version of Dgraph for ensuring that we are running the version that we expect to run.
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
sanjayk-github-dev
approved these changes
Jul 31, 2023
shivaji-dgraph
approved these changes
Jul 31, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
for certain binaries such as v22.0.0, dgraph version that gets printed is "local". We now instead use the commit sha to find the right running version of Dgraph for ensuring that we are running the version that we expect to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for certain binaries such as v22.0.0, dgraph version that gets printed is "local". We now instead use the commit sha to find the right running version of Dgraph for ensuring that we are running the version that we expect to run.