fix(mutation): Mutation request stuck when --limit flag is set #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaji-dgraph
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
shivaji-dgraph
force-pushed
the
shiva/limit
branch
from
9c3a1e2
to
364b3d1
Compare
mangalaman93
approved these changes
Feb 8, 2023
mangalaman93
force-pushed
the
shiva/limit
branch
from
1af7d0f
to
c636e6e
Compare
| @@ -208,7 +208,7 @@ func (s *Server) AssignIds(ctx context.Context, num *pb.Num) (*pb.AssignedIds, e | |||
| // Return error after random delay. | |||
| //nolint:gosec // random generator in closed set does not require cryptographic precision | |||
| delay := rand.Intn(int(opts.limiterConfig.RefillAfter)) | |||
| time.Sleep(time.Duration(delay) * time.Second) | |||
| time.Sleep(time.Duration(delay)) | |||
matthewmcneely
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dgraph-io/projects/issues/87