Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): resolve systest failures on arm #8503

Merged
merged 17 commits into from
Dec 13, 2022
Merged

fix(ci): resolve systest failures on arm #8503

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
adf5666
modify image in systest/export
joshua-goldstein Dec 11, 2022
47301d5
add arch flag
joshua-goldstein Dec 11, 2022
531e3ae
make testing easier and arm work
joshua-goldstein Dec 11, 2022
38a9f13
fix logic error:
joshua-goldstein Dec 11, 2022
380f3be
only remove coverage files in cover mode
joshua-goldstein Dec 11, 2022
567acb6
add custom dirs
joshua-goldstein Dec 11, 2022
b31968c
update comment on dockerfile
joshua-goldstein Dec 12, 2022
634db0c
add comment in t.go
joshua-goldstein Dec 12, 2022
e63d6af
add environment variable
joshua-goldstein Dec 12, 2022
9b72c5a
remove extra docker-compose files
joshua-goldstein Dec 12, 2022
3b175f6
remove compose file arm logic
joshua-goldstein Dec 12, 2022
9c9b5f7
reformat comment
joshua-goldstein Dec 12, 2022
f494305
remove arch flag, check at runtime
joshua-goldstein Dec 12, 2022
6488938
log architecture runtime
joshua-goldstein Dec 12, 2022
7653085
remove arch flag
joshua-goldstein Dec 12, 2022
1a740bd
add default image tag
joshua-goldstein Dec 12, 2022
9c9efed
remove superfluous conditional
joshua-goldstein Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reformat comment
  • Loading branch information
@joshua-goldstein
joshua-goldstein committed Dec 12, 2022
commit 9c9b5f7f4040779fae5f6abaa22018226cc6aab8
4 changes: 2 additions & 2 deletions t/t.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ var (
"comma separated list of packages that needs to be skipped. "+
"Package Check uses string.Contains(). Please check the flag carefully")
runCoverage = pflag.Bool("coverage", false, "Set true to calculate test coverage")
// used to select minio image in systest/{export,backup}
arch = pflag.String("arch", "x86", "Machine architecture. Possible values are [arm64, x86].")
arch = pflag.String("arch", "x86", "Machine architecture. Possible values are [arm64, x86]."+
"Used to select appropriate minio image in systest/{export,backup}")
)

func commandWithContext(ctx context.Context, args ...string) *exec.Cmd {
Expand Down