fix(GraphQL) fix auth query rewriting with ID filter (cherry-pick-7740)

[joshua-goldstein]

Refers to this PR. Cherry pick 7740.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ joshua-goldstein
✅ matthewmcneely
❌ minhaj-shakeel
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coveralls]

Coverage increased (+0.003%) to 37.102% when pulling 50ee38a on cherry-pick-7740 into 9b67017 on main.

[meghalims]

Looks good 👍

[skrdgraph]

@joshua-goldstein - the tests seem to have failed, I am re-running them (because I suspect this must have happened when one of us was mucking with the runners)

[matthewmcneely]

Please don't merge this yet. Getting a panic when testing this locally.

[joshua-goldstein]

Please don't merge this yet. Getting a panic when testing this locally.

Hi Matthew, any idea why this might be happening locally? Do you have a stack trace of the panic? I reran the test on our runners three times and we see the test passing there.

[matthewmcneely]

This was panic-ing if the type coming in from the wild was a simple string—which I'd say is the typical scenario for IDs when encoded in JWTs (taken from some session ID or something).

[matthewmcneely]

@joshua-goldstein, @skrdgraph Could you guys review my recent commits to this branch?

[matthewmcneely]

Please don't merge this yet. Getting a panic when testing this locally.

Hi Matthew, any idea why this might be happening locally? Do you have a stack trace of the panic? I reran the test on our runners three times and we see the test passing there.

@joshua-goldstein The issue was that the tests were not creating all the conditions in which an ID-assigned JWT variable was being passed—namely, the tests covered arrays (slices), but not single values. I uncovered this by actually deploying a graph with auth protected types and running queries with actual JWTs in the requests.

So the fix was to check for that single value, not just the slice. I added another test to cover this condition.

[skrdgraph]

thnx for explaining this, it was easy to understand this @matthewmcneely