fix(proposals): Incremental proposal key for zero proposals #8005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
changed the title
manishrjain
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ahsanbarkati)
dgraph/cmd/zero/raft.go, line 89 at r1 (raw file):
func (n *node) initProposalKey(id uint64) { x.AssertTrue(id != 0) proposalKey = uint64(n.Id)<<48 | uint64(z.FastRand())<<16
You can use crypto.Rand instead of fast rand, which would provide more unique numbers.
NamanJain8
pushed a commit
that referenced
this pull request
Sep 3, 2021
Change the proposal's unique key to an atomic counter instead of using a randomly generated key. (cherry picked from commit a515d0d)
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 4, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 20, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 23, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 24, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 24, 2023
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
all-seeing-code
added a commit
that referenced
this pull request
Feb 8, 2023
…8567) Change the proposal's unique key to an atomic counter instead of using a randomly generated key. Proposal key initialisation has a bug where we want to reserve first 2 bytes for node id but do not do because we read random bytes in all 8 bytes and do a logical OR. This PR adds a test case and fixes the logic of initialising the proposal key. (cherry picked from commit a515d0d) (cherry picked from commit 2aa3d3e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change proposal's unique key to an atomic counter instead of using randomly generated key. For a randomly generated key of 32bits, there is a considerable probability of getting the same key used again.
This change is