release/v21.03: fix(bulk): upsert guardian/groot for all existing namespaces (#7759) #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible. This is because the users/groups were not created for it, if they were not present originally in the RDF. Solution: This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset). (cherry picked from commit c4f4964)
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
github-actions
bot
added
area/bulk-loader
ajeetdsouza
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If the data was loaded into some namespace using bulk loader with --force-namespace, that data wasn't actually accessible.
This is because the users/groups were not created for it, if they were not present originally in the RDF.
Solution:
This PR fixes that by upserting the default user and password for that namespace, when the alpha starts (to be precise, whenever ACL is reset).
(cherry picked from commit c4f4964)
This change is