Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(GraphQL): Add filter in DQL query in case of reverse predicate #7728

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Fix(GraphQL): Add filter in DQL query in case of reverse predicate #7728

merged 4 commits into from
Apr 16, 2021

Conversation

vmrajas
Copy link
Contributor

@vmrajas vmrajas commented Apr 15, 2021 •
edited by manishrjain
Loading

Motivation:
This adds support for having two GraphQL fields linking to the same reverse edge. This also adds corresponding changes to query_rewriter to filter out only the wanted nodes.

Testing:

  1. Add yaml test in query_test.yaml

Fixes GRAPHQL-1140

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Apr 15, 2021
@vmrajas vmrajas merged commit 1743501 into master Apr 16, 2021
@vmrajas vmrajas deleted the rajas/add_type_in_dql_query branch April 16, 2021 11:18
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
03de668 
…7728)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
b1c6ef3 
…7728)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
41ca492 
…7728)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
da0f1a6 
…7728)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
46157a5 
…7728) (#7734)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
vmrajas added a commit that referenced this pull request Apr 16, 2021
@vmrajas
Fix(GraphQL): Add filter in DQL query in case of reverse predicate (#…
00ada83 
…7728) (#7733)

* Add code

* Fix GraphQL schemagen with reverse Dgraph predicates (#7689)

(cherry picked from commit f7c199e)

* Add yaml test

* Fix tests

(cherry picked from commit 1743501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimanyusinghgaur abhimanyusinghgaur abhimanyusinghgaur approved these changes

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmrajas @abhimanyusinghgaur