Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bulk): throw the error instead of crashing #7722

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Apr 14, 2021

The bulk loader crashes before printing out the correct error message.
See https://discuss.dgraph.io/t/how-to-solve-mutation-conflict/13591/13?u=naman


This change is Reviewable

@github-actions github-actions bot added the area/bulk-loader Issues related to bulk loading. label Apr 14, 2021
Copy link
Contributor

@ahsanbarkati ahsanbarkati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NamanJain8 NamanJain8 merged commit a4d74d4 into master Apr 15, 2021
@NamanJain8 NamanJain8 deleted the naman/bulk-attr branch April 15, 2021 10:38
NamanJain8 added a commit that referenced this pull request Apr 26, 2021
NamanJain8 added a commit that referenced this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bulk-loader Issues related to bulk loading.
Development

Successfully merging this pull request may close these issues.

2 participants