-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(GraphQL): @id field uniqueness at interface level - fixes #8434 #7710
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b2b5025
added unique directory
JatinDev543 e61d295
aadded existence query
JatinDev543 bb31c4e
modify rewrite object to check xid across implementation of interface
JatinDev543 5f468ce
fix a panic,added mutation unit tests
JatinDev543 d6e8441
fix test
JatinDev543 9dd3c22
fix test and add more test case for add mutation
JatinDev543 8bc068c
add schema
JatinDev543 1f4cb04
Merge branch 'master' of https://github.com/dgraph-io/dgraph into jat…
JatinDev543 d8a8510
added e2e mutation test
JatinDev543 3c6c61a
clean test
JatinDev543 b437d2f
clean test
JatinDev543 15b4501
clean test
JatinDev543 0dd1ebb
fix spaces
JatinDev543 e00a0df
added interface auth test
JatinDev543 1d2eec5
added some more tests and schema
JatinDev543 4f0a7a6
fix schema test
JatinDev543 8dd224b
clean test
JatinDev543 6f04115
clean code
JatinDev543 2af9a35
clean code
JatinDev543 c2838e2
clean code
JatinDev543 16ae849
fix formatting and test
JatinDev543 8291064
fix formatting
JatinDev543 78f2938
fix test
JatinDev543 4a6a86c
addressed rajas comments
JatinDev543 5a94e2a
changed arg name from unique to interface
JatinDev543 fba56a4
addressed abhimanyu's comments
JatinDev543 ca8e34d
change variable names
JatinDev543 0a147ce
Merge branch 'master' of github.com:dgraph-io/dgraph into jatin/GRAPH…
JatinDev543 9613499
fixed schema test
JatinDev543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
change variable names
- Loading branch information
commit ca8e34d245fe0f40100536d0f1238a63ba4b8b48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline in a call, we will have to handle case of duplicate XID for different implementing types using the variableObjMap or add a TODO