Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GRAPHQL): Undo the breaking change and tag it as deprecated. #7602

Merged
merged 5 commits into from
Mar 18, 2021
Merged

fix(GRAPHQL): Undo the breaking change and tag it as deprecated. #7602

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0d1c89
undo the changes made by GRAPHQL-886
JatinDev543 Mar 17, 2021
07294ae
added deprecated directive for xid argument for get query on interface
JatinDev543 Mar 17, 2021
8943122
modified the deprecated comment
JatinDev543 Mar 18, 2021
70b617f
modified the deprecated comment
JatinDev543 Mar 18, 2021
45f7a6e
modified the deprecated comment
JatinDev543 Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modified the deprecated comment
  • Loading branch information
@JatinDev543
JatinDev543 committed Mar 18, 2021
commit 70b617fc025e87dfb9fde3fde598c8eaed1598ef
2 changes: 1 addition & 1 deletion graphql/schema/gqlschema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,7 +1932,7 @@ func addGetQuery(schema *ast.Schema, defn *ast.Definition, providesTypeMap map[s
qry.Directives, &ast.Directive{Name: deprecatedDirective,
Arguments: ast.ArgumentList{&ast.Argument{Name: "reason",
Value: &ast.Value{Raw: "@id argument for get query on interface is being deprecated, " +
"it will be removed in 21.11, " +
"it will be removed in 21.11.0, " +
"please update your query to not use that argument",
Kind: ast.StringValue}}}})
}
Expand Down
2 changes: 1 addition & 1 deletion graphql/schema/testdata/schemagen/output/interface-with-id-directive.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ input UpdateLibraryInput {
#######################

type Query {
getLibraryItem(refID: String!): LibraryItem @deprecated(reason: "@id argument for get query on interface is being deprecated, it will be removed in 21.11, please update your query to not use that argument")
getLibraryItem(refID: String!): LibraryItem @deprecated(reason: "@id argument for get query on interface is being deprecated, it will be removed in 21.11.0, please update your query to not use that argument")
queryLibraryItem(filter: LibraryItemFilter, order: LibraryItemOrder, first: Int, offset: Int): [LibraryItem]
aggregateLibraryItem(filter: LibraryItemFilter): LibraryItemAggregateResult
getBook(refID: String!): Book
Expand Down