ci: Add GitHub Actions for golangci-lint. #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/integrations
I expect to see bot comments on the GitHub PR.
This reverts commit 80bfec0.
…tions-golangci-lint
Revert before merging.
This reverts commit 5d99fa7.
It's possible that the action times out because of the build cache. The default timeout is 1-minute, so this change doubles the timeout duration. https://github.com/dgraph-io/dgraph/pull/7345/checks?check_run_id=1884418647 run golangci-lint Running [/home/runner/golangci-lint-1.36.0-linux-amd64/golangci-lint run --out-format=github-actions --new-from-patch=/tmp/tmp-2680-QAynk1d0PEVf/pull.patch --new=false --new-from-rev=] in [] ... level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
aman-bansal
pushed a commit
that referenced
this pull request
Apr 7, 2021
This adds golangci-lint[1] to run for every PR. Followed the docs at https://golangci-lint.run/usage/install#github-actions [1]: https://github.com/golangci/golangci-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds golangci-lint to run for every PR.
https://golangci-lint.run/usage/install#github-actions
This change is