fix(vault): vault_format support for online restore and gql #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasssh
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
martinmr
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain, @MichaelJCompton, @parasssh, @pawanrawal, and @vvbalaji-dgraph)
graphql/admin/endpoints_ee.go, line 106 at r1 (raw file):
""" Vault kv store field's format. Must be "base64" or "raw".
include what this defaults to if it's not included.
|
graphql/admin/endpoints_ee.go, line 106 at r2 (raw file):
Quote default value as |
parasssh
pushed a commit
that referenced
this pull request
Jun 29, 2020
(cherry picked from commit 13f630b)
parasssh
pushed a commit
that referenced
this pull request
Jul 2, 2020
arijitAD
pushed a commit
that referenced
this pull request
Jul 14, 2020
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-1744
The new field, vault_format, needs to be supported for online restore and GQL schema.
This change is