Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Apply type filter for get query at root level. #5497

Merged
merged 3 commits into from
Jun 1, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions graphql/resolve/auth_query_test.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,43 @@
- name: "Auth with deep get query."
gqlquery: |
query {
getProject(projID: "0x123") {
projID
columns {
name
colID
}
}
}
dgquery: |-
query {
getProject(func: uid(Project2)) @filter((uid(Project3) AND type(Project))) {
projID : uid
columns : Project.columns @filter(uid(Column1)) {
name : Column.name
colID : uid
}
}
Project2 as var(func: uid(0x123))
Project3 as var(func: uid(Project2)) @cascade {
roles : Project.roles @filter(eq(Role.permission, "VIEW")) {
assignedTo : Role.assignedTo @filter(eq(User.username, "user1"))
dgraph.uid : uid
}
dgraph.uid : uid
}
Column1 as var(func: type(Column)) @cascade {
inProject : Column.inProject {
roles : Project.roles @filter(eq(Role.permission, "VIEW")) {
assignedTo : Role.assignedTo @filter(eq(User.username, "user1"))
dgraph.uid : uid
}
dgraph.uid : uid
}
dgraph.uid : uid
}
}

- name: "Auth with top level filter : query, no filter"
gqlquery: |
query {
Expand Down Expand Up @@ -26,11 +66,11 @@
}
dgquery: |-
query {
getUserSecret(func: uid(UserSecret1)) @filter(uid(UserSecret2)) {
getUserSecret(func: uid(UserSecret1)) @filter((uid(UserSecret2) AND type(UserSecret))) {
id : uid
ownedBy : UserSecret.ownedBy
}
UserSecret1 as var(func: uid(0x123)) @filter(type(UserSecret))
UserSecret1 as var(func: uid(0x123))
UserSecret2 as var(func: uid(UserSecret1)) @filter(eq(UserSecret.ownedBy, "user1")) @cascade
}

Expand Down
17 changes: 14 additions & 3 deletions graphql/resolve/query_rewriter.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,18 @@ func addArgumentsToField(dgQuery *gql.GraphQuery, field schema.Field) {
addPagination(dgQuery, field)
}

func getRootQuery(query *gql.GraphQuery, rootName string) (*gql.GraphQuery, bool) {
for _, q := range query.Children {
if q.Attr == rootName {
return q, true
}
if childQuery, ok := getRootQuery(q, rootName); ok {
return childQuery, true
}
}
return query, false
}

func rewriteAsGet(
field schema.Field,
uid uint64,
Expand All @@ -256,11 +268,10 @@ func rewriteAsGet(
if dgQuery.Attr != "" {
addTypeFilter(dgQuery, field.Type())
} else {
addTypeFilter(dgQuery.Children[1], field.Type())
rootQuery, _ := getRootQuery(dgQuery, field.Name())
addTypeFilter(rootQuery, field.Type())
}

return dgQuery

}

xidArgName := field.XIDArg()
Expand Down