Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pre-allocated protobufs during backups. #5404

Merged
merged 10 commits into from
May 22, 2020
Merged

Use pre-allocated protobufs during backups. #5404

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f354d9
Use a sync pool to store posting lists during backup.
martinmr May 8, 2020
13d8645
Use a pre-allocated array instead of a sync.Pool.
martinmr May 12, 2020
b0bd39f
Merge remote-tracking branch 'origin/master' into martinmr/backup-pools
martinmr May 18, 2020
322a13d
Update badger version.
martinmr May 18, 2020
7e38b1e
Update logic to use thread id from the iterator.
martinmr May 18, 2020
724dba8
Update badger version.
martinmr May 18, 2020
a69d9be
Fix deepsource warnings.
martinmr May 19, 2020
a239843
Merge remote-tracking branch 'origin/master' into martinmr/backup-pools
martinmr May 22, 2020
f770de6
Update badger.
martinmr May 22, 2020
e5ba765
Address review comments.
martinmr May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update logic to use thread id from the iterator.
  • Loading branch information
@martinmr
martinmr committed May 18, 2020
commit 7e38b1ed1b388ebccc15a3f3bcc7cb4016870200
6 changes: 3 additions & 3 deletions worker/backup_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (pr *BackupProcessor) WriteBackup(ctx context.Context) (*pb.Status, error)
stream := pr.DB.NewStreamAt(pr.Request.ReadTs)
stream.LogPrefix = "Dgraph.Backup"
stream.NumGo = backupNumGo
stream.KeyToListWithThreadNum = pr.toBackupList
stream.KeyToList = pr.toBackupList
stream.ChooseKey = func(item *badger.Item) bool {
parsedKey, err := x.Parse(item.Key())
if err != nil {
Expand Down Expand Up @@ -216,7 +216,7 @@ func (m *Manifest) GoString() string {
m.Since, m.Groups, m.Encrypted)
}

func (pr *BackupProcessor) toBackupList(key []byte, itr *badger.Iterator, threadNum int) (
func (pr *BackupProcessor) toBackupList(key []byte, itr *badger.Iterator) (
*bpb.KVList, error) {
list := &bpb.KVList{}

Expand Down Expand Up @@ -248,7 +248,7 @@ func (pr *BackupProcessor) toBackupList(key []byte, itr *badger.Iterator, thread
}
kv.Key = backupKey

backupPl, err := pr.toBackupPostingList(kv.Value, threadNum)
backupPl, err := pr.toBackupPostingList(kv.Value, itr.ThreadId)
if err != nil {
return nil, err
}
Expand Down