-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown executor goroutines #5130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention the JIRA ticket this corresponds to?
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
I see the following error on this branch line https://github.com/dgraph-io/dgraph/pull/5130/files#diff-e7949a0879bc67d5514e8a008bab05bfR909
|
Thanks for pointing @jarifibrahim . My recent commit should have fixed the issue. |
We were not waiting for the executor goroutines to shutdown. Also we were trying to close the goroutines as soon as ctrl+c is hit.
This change would ensure that all the pending mutations are applied before goroutines are shutdown.
And we are also waiting for all such executor goroutines to finish before dgraph shuts down.
This change is