graphql: Fix deleteGroup and deleteUser mutations. #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op all, also add a test for deleteUser
… not deleting it from user's groups.
golangcibot
reviewed
Feb 20, 2020
|
|
||
| InitialTypes = ` | ||
| "types": [{"fields": [{"name": "dgraph.graphql.schema"}],"name": "dgraph.graphql"}, | ||
| {"fields": [{"name": "dgraph.password"},{"name": "dgraph.xid"},{"name": "dgraph.user.group"}],"name": "User"}, |
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @harshil-goel, @manishrjain, @MichaelJCompton, and @pawanrawal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteGroup should also delete the group from the user group lists that it belongs to. This was not happening before because we were not adding the delete mutation like we do for fields which have the
@hasInversedirective. This happens now.deleteUser should also delete the user from the groups that it belongs to. This was not happening because Dgraph didn't have the type info for
Usertype and wasn't correctly deleting its edges. Now the type information is added to the list of initial types.This change is
Docs Preview: