Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform incremental rollups instead of rollups at snapshot #4410

Merged
merged 17 commits into from
Jan 9, 2020
Merged

Perform incremental rollups instead of rollups at snapshot #4410

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
31d62e4
best-effort / lossy on sender; batch on receiver; use sync.pool
Nov 21, 2019
91343eb
cleanups, map uses hash(key), struct, bring all methods in struct type
Nov 27, 2019
c68273c
go fmt
Nov 27, 2019
d5eb7a4
Merge remote-tracking branch 'origin/master' into ps_incremental_rollups
Dec 12, 2019
109d077
go fmt
Dec 12, 2019
4f0b6ab
import fix
Dec 12, 2019
ecda6fb
bot comments
Dec 12, 2019
3d68c4f
cleanup
Dec 12, 2019
1f23de2
address Manish's review comments
Jan 3, 2020
816c539
dont make rollupKey public
Jan 3, 2020
0c33fc5
address review comments
Jan 3, 2020
3a01589
golang ci fix
Jan 3, 2020
7ae4b36
address review comments
Jan 7, 2020
bfef6e7
Merge remote-tracking branch 'origin/master' into ps_incremental_rollups
Jan 7, 2020
0c8b082
address review comments
Jan 9, 2020
ddfe38a
revert back to using pointer to slice as DeepSource complained
Jan 9, 2020
c9aa143
addr review comments; minor cleanups
Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont make rollupKey public
  • Loading branch information
Paras Shah committed Jan 3, 2020
commit 816c5395eb5753dca03b288d47982b95b06128ab
6 changes: 3 additions & 3 deletions posting/mvcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ var (
}
)

// RollUpKey takes the given key's posting lists, rolls it up and writes back to badger
func (ir *IncRollup) RollUpKey(writer *TxnWriter, key []byte) error {
// rollUpKey takes the given key's posting lists, rolls it up and writes back to badger
func (ir *IncRollup) rollUpKey(writer *TxnWriter, key []byte) error {
l, err := GetNoStore(key)
if err != nil {
return err
Expand Down Expand Up @@ -103,7 +103,7 @@ func (ir *IncRollup) HandleIncrementalRollups() {
// Key not present or Key present but last roll up was more than 10 sec ago.
// Add/Update map and rollup.
m[hash] = currTs
err := ir.RollUpKey(writer, key)
err := ir.rollUpKey(writer, key)
if err != nil {
glog.Warningf("Error %v rolling up key %v\n", err, key)
continue
Expand Down