Don't traverse immutable layer if deleteBelowTs > 0 #4204
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@pawanrawal you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Have Manish take a look at this just to be sure.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pawanrawal)
posting/list.go, line 105 at r2 (raw file):
func (it *pIterator) init(l *List, afterUid, deleteBelowTs uint64) error { if deleteBelowTs > 0 && deleteBelowTs <= l.minTs {
Please check when it broke. And add that PR which broke it in the description.
| }`, ` | ||
| { | ||
| "me": [] | ||
| }`)) |
There was a problem hiding this comment.
I think this format would be better for readability:
}`,
),
)
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| t.Run("Get list of friends", s.testCase(` |
There was a problem hiding this comment.
Let's have s.testCase( to be on a new line for readability.
S P *deletions were not working when data was loaded using bulk loader or was in the immutable layer. This PR makes sure we don't iterate over the immutable layer when we have a delete marker. Earlier after doing aS P *deletion, we were still returning the first uid from the immutable layer.Fixes #4182
This bug was introduced in #3105.
This change is