Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint warnings. #3821

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix golint warnings. #3821

merged 1 commit into from
Aug 15, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Aug 15, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested review from manishrjain and a team as code owners August 15, 2019 20:57
pullrequest[bot]
pullrequest bot reviewed Aug 15, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@martinmr you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Aug 15, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

pullrequest[bot]
pullrequest bot reviewed Aug 15, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here all look good. Nice job cleaning up these warnings 👏

Reviewed with ❤️ by PullRequest

@martinmr martinmr merged commit f69e6af into master Aug 15, 2019
@martinmr martinmr deleted the martinmr/fix-golint branch August 15, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest PullRequest PullRequest left review comments

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinmr