Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more errcheck warnings. #3611

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Fix more errcheck warnings. #3611

merged 2 commits into from
Jun 28, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Jun 28, 2019

This change is Reviewable

@martinmr martinmr requested review from manishrjain and a team as code owners June 28, 2019 00:11
@martinmr martinmr requested review from campoy and danielmai and removed request for manishrjain June 28, 2019 00:11
campoy
campoy previously requested changes Jun 28, 2019
Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @martinmr)


contrib/integration/bank/main.go, line 173 at r1 (raw file):

	ctx := context.Background()
	txn := dg.NewTxn()
	defer func() { _ = txn.Discard(context.Background()) }()

Maybe you should actually log something if the error is not nil?
It will also make the code a bit less awkward.

Same for the similar change below.

Copy link
Contributor Author

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @campoy and @danielmai)


contrib/integration/bank/main.go, line 173 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

Maybe you should actually log something if the error is not nil?
It will also make the code a bit less awkward.

Same for the similar change below.

Done.

@martinmr martinmr requested a review from campoy June 28, 2019 19:16
@martinmr martinmr dismissed campoy’s stale review June 28, 2019 19:16

addressed review

Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @campoy and @danielmai)

Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai)

@martinmr martinmr merged commit 1dc8d1b into master Jun 28, 2019
@martinmr martinmr deleted the martinmr/fix-errcheck branch June 28, 2019 20:40
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants