-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more errcheck warnings. #3611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @martinmr)
contrib/integration/bank/main.go, line 173 at r1 (raw file):
ctx := context.Background() txn := dg.NewTxn() defer func() { _ = txn.Discard(context.Background()) }()
Maybe you should actually log something if the error is not nil?
It will also make the code a bit less awkward.
Same for the similar change below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @campoy and @danielmai)
contrib/integration/bank/main.go, line 173 at r1 (raw file):
Previously, campoy (Francesc Campoy) wrote…
Maybe you should actually log something if the error is not nil?
It will also make the code a bit less awkward.Same for the similar change below.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @campoy and @danielmai)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @danielmai)
This change is