Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dart client to README and clients page. #2804

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add Dart client to README and clients page. #2804

merged 1 commit into from
Dec 4, 2018

Conversation

marceloneppel
Copy link
Contributor

@marceloneppel marceloneppel commented Dec 3, 2018

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2018

CLA assistant check
All committers have signed the CLA.

@danielmai
Copy link
Contributor

Congrats on releasing this new Dart client for Dgraph, @katutz. Have you thought about giving the client library a different name other than plain "dgraph"?

Thanks for your contribution!

@danielmai danielmai merged commit 666f4d7 into dgraph-io:master Dec 4, 2018
@marceloneppel
Copy link
Contributor Author

marceloneppel commented Dec 4, 2018

Congrats on releasing this new Dart client for Dgraph, @katutz. Have you thought about giving the client library a different name other than plain "dgraph"?

Thanks for your contribution!

Thanks @danielmai! I thought in using some other name like ddgraph or dgraph_dart. But I was in doubt, because I saw some clients in Dart with the same name as theirs databases and others with a different name. Then I initially used the same name to reserve the dgraph package name in the Dart Pub (Dart package repository). Would it be interesting to switch to one of these names I thought or some other?

@marceloneppel marceloneppel deleted the dart_client branch December 4, 2018 11:01
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants