-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace TxnWriter with WriteBatch (#5007)
* Replace txnWriter with WriteBatch * Add benchmark file writer_test.go Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com> Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
- Loading branch information
3 people
authored
May 6, 2020
1 parent
cbc764b
commit 20494f9
Showing
6 changed files
with
254 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,240 @@ | ||
| /* | ||
| * Copyright 2020 Dgraph Labs, Inc. and Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package posting | ||
|
|
||
| import ( | ||
| "io/ioutil" | ||
| "math" | ||
| "os" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/dgraph-io/badger/v2" | ||
| "github.com/dgraph-io/badger/v2/options" | ||
| bpb "github.com/dgraph-io/badger/v2/pb" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var val = make([]byte, 128) | ||
|
|
||
| func BenchmarkWriter(b *testing.B) { | ||
| createKVList := func() bpb.KVList { | ||
| var KVList bpb.KVList | ||
| for i := 0; i < 5000000; i++ { | ||
| n := &bpb.KV{Key: []byte(string(i)), Value: val, Version: 5} | ||
| KVList.Kv = append(KVList.Kv, n) | ||
| } | ||
| return KVList | ||
| } | ||
|
|
||
| // Creates separate writer for each thread | ||
| writeInBadgerMThreadsB := func(db *badger.DB, KVList *bpb.KVList, wg *sync.WaitGroup) { | ||
| defer wg.Done() | ||
| wb := db.NewManagedWriteBatch() | ||
| if err := wb.Write(KVList); err != nil { | ||
| panic(err) | ||
| } | ||
| require.NoError(b, wb.Flush()) | ||
|
|
||
| } | ||
|
|
||
| // Resuses one writer for all threads | ||
| writeInBadgerMThreadsW := func(wb *badger.WriteBatch, KVList *bpb.KVList, wg *sync.WaitGroup) { | ||
| defer wg.Done() | ||
|
|
||
| if err := wb.Write(KVList); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| } | ||
| // Creates separate writer for each thread | ||
| writeInBadgerSingleThreadB := func(db *badger.DB, KVList *bpb.KVList) { | ||
| wb := db.NewManagedWriteBatch() | ||
| if err := wb.Write(KVList); err != nil { | ||
| panic(err) | ||
| } | ||
| require.NoError(b, wb.Flush()) | ||
|
|
||
| } | ||
| // Resuses one writer for all threads | ||
| writeInBadgerSingleThreadW := func(wb *badger.WriteBatch, KVList *bpb.KVList) { | ||
| if err := wb.Write(KVList); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| dbOpts := badger.DefaultOptions(""). | ||
| WithLogger(nil). | ||
| WithSyncWrites(false). | ||
| WithNumVersionsToKeep(math.MaxInt64). | ||
| WithCompression(options.None) | ||
|
|
||
| KVList := createKVList() | ||
|
|
||
| // Vanilla TxnWriter | ||
| b.Run("TxnWriter", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| w := NewTxnWriter(db) | ||
| for _, typ := range KVList.Kv { | ||
| k := typ.Key | ||
| v := typ.Value | ||
| err := w.SetAt(k, v, BitSchemaPosting, 1) | ||
| require.NoError(b, err) | ||
| } | ||
| require.NoError(b, w.Flush()) | ||
|
|
||
| } | ||
| }) | ||
| // Single threaded BatchWriter | ||
| b.Run("WriteBatch1", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
|
|
||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| wb := db.NewManagedWriteBatch() | ||
| if err := wb.Write(&KVList); err != nil { | ||
| panic(err) | ||
| } | ||
| require.NoError(b, wb.Flush()) | ||
| } | ||
| }) | ||
| // Multi threaded Batchwriter with thread contention in WriteBatch | ||
| b.Run("WriteBatchMultThreadDiffWB", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
|
|
||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| var wg sync.WaitGroup | ||
| wg.Add(5) | ||
|
|
||
| go writeInBadgerMThreadsB(db, &bpb.KVList{Kv: KVList.Kv[:1000000]}, &wg) | ||
| go writeInBadgerMThreadsB(db, &bpb.KVList{Kv: KVList.Kv[1000001:2000000]}, &wg) | ||
| go writeInBadgerMThreadsB(db, &bpb.KVList{Kv: KVList.Kv[2000001:3000000]}, &wg) | ||
| go writeInBadgerMThreadsB(db, &bpb.KVList{Kv: KVList.Kv[3000001:4000000]}, &wg) | ||
| go writeInBadgerMThreadsB(db, &bpb.KVList{Kv: KVList.Kv[4000001:]}, &wg) | ||
| wg.Wait() | ||
|
|
||
| } | ||
| }) | ||
| // Multi threaded Batchwriter with thread contention in SetEntry | ||
| b.Run("WriteBatchMultThreadSameWB", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
|
|
||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| var wg sync.WaitGroup | ||
| wg.Add(5) | ||
| wb := db.NewManagedWriteBatch() | ||
| go writeInBadgerMThreadsW(wb, &bpb.KVList{Kv: KVList.Kv[:1000000]}, &wg) | ||
| go writeInBadgerMThreadsW(wb, &bpb.KVList{Kv: KVList.Kv[1000001:2000000]}, &wg) | ||
| go writeInBadgerMThreadsW(wb, &bpb.KVList{Kv: KVList.Kv[2000001:3000000]}, &wg) | ||
| go writeInBadgerMThreadsW(wb, &bpb.KVList{Kv: KVList.Kv[3000001:4000000]}, &wg) | ||
| go writeInBadgerMThreadsW(wb, &bpb.KVList{Kv: KVList.Kv[4000001:]}, &wg) | ||
|
|
||
| wg.Wait() | ||
| require.NoError(b, wb.Flush()) | ||
| } | ||
| }) | ||
| b.Run("WriteBatchSingleThreadDiffWB", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
|
|
||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| writeInBadgerSingleThreadB(db, &bpb.KVList{Kv: KVList.Kv[:1000000]}) | ||
| writeInBadgerSingleThreadB(db, &bpb.KVList{Kv: KVList.Kv[1000001:2000000]}) | ||
| writeInBadgerSingleThreadB(db, &bpb.KVList{Kv: KVList.Kv[2000001:3000000]}) | ||
| writeInBadgerSingleThreadB(db, &bpb.KVList{Kv: KVList.Kv[3000001:4000000]}) | ||
| writeInBadgerSingleThreadB(db, &bpb.KVList{Kv: KVList.Kv[4000001:]}) | ||
| } | ||
| }) | ||
| b.Run("WriteBatchSingleThreadSameWB", func(b *testing.B) { | ||
| tmpIndexDir, err := ioutil.TempDir("", "dgraph") | ||
| require.NoError(b, err) | ||
| defer os.RemoveAll(tmpIndexDir) | ||
|
|
||
| dbOpts.Dir = tmpIndexDir | ||
| dbOpts.ValueDir = tmpIndexDir | ||
|
|
||
| var db, err2 = badger.OpenManaged(dbOpts) | ||
| require.NoError(b, err2) | ||
| defer db.Close() | ||
|
|
||
| b.ResetTimer() | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| wb := db.NewManagedWriteBatch() | ||
| writeInBadgerSingleThreadW(wb, &bpb.KVList{Kv: KVList.Kv[:1000000]}) | ||
| writeInBadgerSingleThreadW(wb, &bpb.KVList{Kv: KVList.Kv[1000001:2000000]}) | ||
| writeInBadgerSingleThreadW(wb, &bpb.KVList{Kv: KVList.Kv[2000001:3000000]}) | ||
| writeInBadgerSingleThreadW(wb, &bpb.KVList{Kv: KVList.Kv[3000001:4000000]}) | ||
| writeInBadgerSingleThreadW(wb, &bpb.KVList{Kv: KVList.Kv[4000001:]}) | ||
| require.NoError(b, wb.Flush()) | ||
| } | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters