Added Big Float to api.Value #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@harshil-goel you can click here to see the review status or cancel the code review job.
|
|
There was a problem hiding this comment.
Looks good and adds the new type in the protobuf definition and code
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard
mangalaman93
force-pushed
the
harshil-goel/added-bigfloat-proto
branch
from
ed6febe
to
c4af0a8
Compare
mangalaman93
force-pushed
the
harshil-goel/added-bigfloat-proto
branch
from
c4af0a8
to
72b4d7c
Compare
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
shivaji-dgraph
force-pushed
the
harshil-goel/added-bigfloat-proto
branch
from
72b4d7c
to
fb2fe59
Compare
shivaji-dgraph
force-pushed
the
harshil-goel/added-bigfloat-proto
branch
from
fb2fe59
to
31c0382
Compare
shivaji-dgraph
force-pushed
the
harshil-goel/added-bigfloat-proto
branch
from
31c0382
to
996029c
Compare
mangalaman93
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is