Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for vector data types. #177

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

billprovince
Copy link
Contributor

Starting development for direct support of Vectors of Float64 values.

(Not yet ready for full review!!)

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RJKeevil
Copy link

Great to see work on this starting! Quick comment, most huggingface sentence similarity LLMs typically produce Float32 values, so can I ask that these be supported also? Should help a little with storage size and processing speed.

@billprovince
Copy link
Contributor Author

Great to see work on this starting! Quick comment, most huggingface sentence similarity LLMs typically produce Float32 values, so can I ask that these be supported also? Should help a little with storage size and processing speed.

Ah! I knew that there are strong advantages to using Float32, but did not realize that huggingface directly preferred this! Thanks for the feedback, @RJKeevil . Be aware that the server doesn't directly support this at the moment, but we will be sure to announce when it is ready!

@mangalaman93 mangalaman93 merged commit 7b8d289 into master Mar 14, 2024
4 of 5 checks passed
@mangalaman93 mangalaman93 deleted the AddVectorSupport branch March 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants